Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.19] Emit E2E Test Instance Metrics in Release 0.19 #8806

Closed
wants to merge 1 commit into from

Conversation

jhaanvi5
Copy link
Member

@jhaanvi5 jhaanvi5 commented Sep 23, 2024

Issue

E2E metrics are not logged when we do patch release for release-0.19, CloudWatch module needed to push metrics was not backported to release-0.19

Description of changes:

This PR add support for pushing e2e metrics for release-0.19 branch.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign drewvanstone for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 23, 2024
@jhaanvi5 jhaanvi5 changed the title Add emitting of e2e test instance metrics in release-0.19 Emit E2E Test Instance Metrics in Release 0.19 Sep 23, 2024
@sp1999
Copy link
Member

sp1999 commented Sep 23, 2024

#8098 (comment)
This was cancelled before due to merge conflict. Do you know if that has been fixed in this PR?

@sp1999 sp1999 changed the title Emit E2E Test Instance Metrics in Release 0.19 [release-0.19] Emit E2E Test Instance Metrics in Release 0.19 Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants